Wireshark mailing list archives
Re: [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c
From: Jakub Zawadzki <darkjames () darkjames ath cx>
Date: Tue, 20 Apr 2010 10:41:55 +0200
Hi, On Tue, Apr 20, 2010 at 10:22:11AM +0200, Stig Bj?rlykke wrote:
On Tue, Apr 20, 2010 at 9:47 AM, <etxrab () wireshark org> wrote:From Jakub Zawadzki: Improve bitview displayThis patch introduces the bugs listed in comment 1 in the bug report. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4413#c1
- Selecting bits in the bit view does not always select the correct tree entry. (both integer and boolean values)
I can reporduce this bug without patch.
- I don't think we should highlight parts of a byte in hex view.
It's fixed in new version.
- We should fix the LE vs BE for multi byte entries before adding such a patch.
(Temporary) Disabled for len > 1...
I'm a bit concerned that we will get a lot of dissector "bugs", like the ip.flags and ip.version.
It's should be fixed by dissectors maintainers anyway. It might be easier to fix it with this patch commited. Cheers. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c Stig Bjørlykke (Apr 20)
- Re: [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c Jakub Zawadzki (Apr 20)
- Re: [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c Jakub Zawadzki (Apr 20)
- Re: [Wireshark-commits] rev 32522: /trunk/gtk/ /trunk/gtk/: main_proto_draw.c Jakub Zawadzki (Apr 20)