tcpdump mailing list archives
Re: strlcpy() in tcpslice
From: Francois-Xavier Le Bail via tcpdump-workers <tcpdump-workers () lists tcpdump org>
Date: Tue, 25 Aug 2020 20:03:03 +0200
--- Begin Message --- From: Francois-Xavier Le Bail <devel.fx.lebail () orange fr>
Date: Tue, 25 Aug 2020 20:03:03 +0200
On 25/08/2020 19:44, Denis Ovsienko via tcpdump-workers wrote:+[missing/strlcpy.c:46]: (style) The function 'strlcpy' is never used. (Which is true, but neither GCC nor Clang complain about that.) LBL code never used strlcpy(), it appeared in TTG code in 2001 via commit fc7de60. Considering long-term maintenance, would it be better to lose the unused missing/strlcpy.c now, or to wait a bit, or to keep it around for as long as it compiles?Hello Denis, strlcpy is used here: tcpslice.c:999: strlcpy(buf, asctime(t), 128); With my build: gcc [...] -g -O2 -o strlcpy.o -c ./missing/strlcpy.c -- Francois-Xavier
--- End Message ---
_______________________________________________ tcpdump-workers mailing list tcpdump-workers () lists tcpdump org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Current thread:
- strlcpy() in tcpslice Denis Ovsienko via tcpdump-workers (Aug 25)
- Re: strlcpy() in tcpslice Francois-Xavier Le Bail via tcpdump-workers (Aug 25)