tcpdump mailing list archives

[libpcap] $libdir check in pcap-config.in


From: eno <coffe92 () gmail com>
Date: Tue, 29 Jan 2019 20:21:56 +0300

Dear experts,

Could somebody tell is this changes are reasonable?
The pcap-config.in file have the following check that if $libdir is
not /usr/lib then set RPATH env:
if [ "$libdir" != "/usr/lib" ]
then
    RPATH=$V_RPATH_OPT$libdir
fi

The problem is if the build system is x86_64 then $libdir will be
probably /usr/lib64 so this check sets $RPATH env and add -rpath to
the $LIBS in Makefile and /usr/bin/pcap-config.
It is not really a problem but I believe it will be more convenient to
rewrite it to something like this:
if ldconfig -v 2> /dev/null | grep -xq "^$libdir:"
then
    RPATH=$V_RPATH_OPT$libdir
fi

What do you think?

-- 
Thanks,
Nikita
B8 4C 00 CD 21
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Current thread: