Re: [RFC TCPDUMP PATCH 0/2] LINKTYPE_LINUX_SLL2 implementation

[Petr Vorel <pvorel () suse cz>]

Hi Guy,

> On Jul 12, 2018, at 11:33 AM, Petr Vorel <pvorel () suse cz> wrote:

> > Main problem is that libpcap supports only one from LINKTYPE_LINUX_SLL
> > and LINKTYPE_LINUX_SLL2

> Not in the version in the libpcap Git repository; both are supported.

> > Tests (make check) are broken as the output is different [2].

> Not in the version in the tcpdump Git repository; it supports both DLT_LINUX_SLL and DLT_LINUX_SLL2.

> > There is no warning/detection about using different version than libpcap
> > uses (libpcap using LINKTYPE_LINUX_SLL and we use LINKTYPE_LINUX_SLL2
> > and vice versa).

> Given that, in the Git repository versions, there are no such configuration options, this is not an issue.

My comments were referring to my previous patch sent to ML (as it's visible in
original post). Thanks for your DLT_LINUX_SLL2 implementation in both, good that
missing features was done :).


Kind regards,
Petr
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers