Re: about pcap_set_protocol()

[Denis Ovsienko <denis () ovsienko info>]

 ---- On Wed, 11 Jul 2018 06:14:41 +0100 Francois-Xavier Le Bail <devel.fx.lebail () orange fr> wrote ---- 
> On 11/07/2018 04:15, Guy Harris wrote:
> > On Jul 10, 2018, at 1:31 AM, Denis Ovsienko <denis () ovsienko info> wrote:
> >
> > > I have been looking at the man page for pcap_set_protocol() for some time. The man page explains the function is 
> > > a Linux-specific extension. Would it be better to rename the function to something like pcap_set_linux_protocol() 
> > > before it is too late? The function was added to the master branch in June 2017 (libpcap pull request #595) and 
> > > it has not made it into a libpcap release yet.
> >
> > Or pcap_linux_set_protocol()/pcap_set_protocol_linux(); perhaps in cases where we add platform-specific functions, 
> > put the platform name after pcap_ or at the end of the name, to have a general pattern (it's too late for some of 
> > the Windows-specific ones, but many of them are either obsolete with generic replacements, Windows-specific 
> > because of inherent UN*X vs. Windows differences so it's somewhat implied, or no longer supported).
>
> I'd rather pcap_set_protocol_linux(), because we already have functions like
> pcap_activate_linux(), pcap_can_set_rfmon_linux(), pcap_cleanup_linux(), pcap_inject_linux(),
> pcap_read_linux(), pcap_set_datalink_linux(), pcap_setdirection_linux(), pcap_setfilter_linux(),
> pcap_stats_linux().

Alright, commit 697b1f7 does that.

-- 
    Denis Ovsienko


_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers