Re: [PATCH net 1/2] net: dev_queue_xmit_nit: fix skb->vlan_tci field value

[Ani Sinha <ani () aristanetworks com>]

On Wed, Jan 9, 2013 at 12:01 PM, Ani Sinha <ani () aristanetworks com> wrote:
> On Wed, Jan 9, 2013 at 11:51 AM, Eric Dumazet <eric.dumazet () gmail com> wrote:
> > On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote:
> >
> > > This is wrong. Accelerated or not, the kernel code was organized to
> > > have the tags in the packet aux data. So I think this is how user land
> > > should be coded as well.
> >
> > You have your opinion, thats good.
> >
> > My opinion as a kernel developer is that the network tap is here to have
> > a copy of the exact frame given to the _device_.
>
> It is fine by me if that is how you see it. In that case. the
> behaviour can me made symmetric on both TX and RX. Tap processing in
> __netif_receive_skb() can be done before vlan_untag() so that taps see
> the exact frame received from the _device_ as you put it.

Although for accelerated vlan tags, it will be in the meta data
anyways. All I am asking is, let's have the same behaviour on both TX
and RX. If  the tag in the packet let's have it that way in both ways
in what the tap sees.
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers