Re: autoconf and patches

[Guy Harris <guy () alum mit edu>]

On Jul 10, 2011, at 9:16 AM, Jakub Zawadzki wrote:

> On Sat, Jul 09, 2011 at 10:37:55PM -0400, Michael Richardson wrote:
> > Just a general  comment about patches:
> >  - try not to include "configure" in your patch. From a developer
> >    point of view, this is a generated file, and any patch it generally
> >    big and irrelevant, and just confuses people reading your patch
> >    for actual information.
>
> So maybe it should be added to .gitignore?

...or removed from Git?  Wireshark doesn't put the automake-generated or autoconf-generated files into SVN; this means 
that if you're building from SVN, you need to run a script to generate those files, and that the process of building a 
release source tarball needs to generate the files before making the tarball, but it means that patches are less likely 
to include changes to the generated files, and that people who check in a change to configure.in or aclocal.m4 don't 
need to remember to regenerate the configure script (I've forgotten to do that on occasion).

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.