Re: [Patch] Host Identity Protocol

[Samu Varjonen <samu.varjonen () hiit fi>]

Hi,

Sorry for delayd answer. I will look into your suggestions/commnents and 
revise the patch accordingly as soon as possible and I'll resend the 
patch to the list.

Guy Harris kirjoitti:
> On Jul 10, 2009, at 2:16 AM, Varjonen Samu wrote:
>
> > diff -N -r -u --strip-trailing-cr tcpdump-orig/configure.in 
> > tcpdump/configure.in
> > --- tcpdump-orig/configure.in    2009-05-20 11:29:46.000000000 +0300
> > +++ tcpdump/configure.in    2009-05-17 13:13:13.000000000 +0300
> > @@ -158,7 +158,7 @@
> >   --disable-ipv6          disable ipv6 support],
> > [ case "$enableval" in
> > yes)   AC_MSG_RESULT(yes)
> > -       LOCALSRC="print-ip6.c print-ip6opts.c print-mobility.c 
> > print-ripng.c print-icmp6.c print-frag6.c print-rt6.c print-ospf6.c 
> > print-dhcp6.c $LOCALSRC"
> > +       LOCALSRC="print-ip6.c print-ip6opts.c print-mobility.c 
> > print-ripng.c print-icmp6.c print-frag6.c print-rt6.c print-ospf6.c 
> > print-dhcp6.c print-hip.c $LOCALSRC"
> >        AC_DEFINE(INET6)
> >        ipv6=yes
> >        ;;
> > diff -N -r -u --strip-trailing-cr tcpdump-orig/interface.h 
> > tcpdump/interface.h
> > --- tcpdump-orig/interface.h    2009-05-20 11:29:46.000000000 +0300
> > +++ tcpdump/interface.h    2009-05-17 13:15:00.000000000 +0300
> > @@ -336,6 +336,7 @@
> > extern int rt6_print(const u_char *, const u_char *);
> > extern void ospf6_print(const u_char *, u_int);
> > extern void dhcp6_print(const u_char *, u_int);
> > +extern void hip_print(const u_char *, u_int);
> > #endif /*INET6*/
> > extern u_short in_cksum(const u_short *, register u_int, int);
> > extern u_int16_t in_cksum_shouldbe(u_int16_t, u_int16_t);
>
> Those seem to imply this is IPv6-only, but:
>
> > diff -N -r -u --strip-trailing-cr tcpdump-orig/print-ip.c 
> > tcpdump/print-ip.c
> > --- tcpdump-orig/print-ip.c    2009-05-20 11:29:46.000000000 +0300
> > +++ tcpdump/print-ip.c    2009-05-18 20:09:48.000000000 +0300
> > @@ -519,6 +519,10 @@
> >         pgm_print(ipds->cp, ipds->len, (const u_char *)ipds->ip);
> >         break;
> >
> > +        case IPPROTO_HIP:
> > +        hip_print(ipds->cp, ipds->len);
> > +        break;
> > +
> >     default:
> >         if ((proto = getprotobynumber(ipds->nh)) != NULL)
> >             ND_PRINT((ndo, " %s", proto->p_name));
>
> that doesn't.  Should this be compiled in if INET6 isn't defined (i.e., 
> if this is a version of tcpdump that doesn't support IPv6)?
> -
> This is the tcpdump-workers list.
> Visit https://cod.sandelman.ca/ to unsubscribe.


--
BR,
Samu

"Programmer is an organism that changes caffeine into code"
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.