tcpdump mailing list archives
Fwd: [PATCH] fix printing of tcp seqno for data segments
From: Romain Francoise <rfrancoise () debian org>
Date: Sun, 01 Mar 2009 15:36:11 +0100
I received the following patch from Ilpo Järvinen through the Debian BTS (http://bugs.debian.org/517661): --- [PATCH] fix printing of tcp seqno for data segments The new formatting carelessly removed this check and put it inside the block only, meaning that seqno won't be printed at all unless at least -v -v are given. Signed-off-by: Ilpo Järvinen <ilpo.jarvinen () helsinki fi> --- print-tcp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/print-tcp.c b/print-tcp.c index 17c1775..c8c2b90 100644 --- a/print-tcp.c +++ b/print-tcp.c @@ -452,7 +452,7 @@ tcp_print(register const u_char *bp, register u_int length, #endif length -= hlen; - if (vflag > 1 || flags & (TH_SYN | TH_FIN | TH_RST)) { + if (vflag > 1 || length > 0 || flags & (TH_SYN | TH_FIN | TH_RST)) { (void)printf(", seq %u", seq); if (length > 0) { -- Romain Francoise <rfrancoise () debian org> http://people.debian.org/~rfrancoise/ - This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
Current thread:
- Fwd: [PATCH] fix printing of tcp seqno for data segments Romain Francoise (Mar 01)
- Re: Fwd: [PATCH] fix printing of tcp seqno for data segments Guy Harris (Mar 01)