tcpdump mailing list archives

Re: print-tcp.c: remove commas from output, to be consistent


From: Hannes Gredler <hannes () juniper net>
Date: Mon, 29 Jan 2007 11:05:43 +0100

On Sun, Jan 28, 2007 at 10:54:44AM -0800, Kevin Steves wrote:
| On Thu, Jan 18, 2007 at 08:36:34AM +0100, Hannes Gredler wrote:
| : well the correct thing would then be:
| : 
| : 1. embrace .SFP into Flags [.SPF],
| : 2. add commas to sep. the rest of the field
| 
| I don't see commas (in general) adding to readability of fields
| when you have 'field-name value' or when position identifies
| field (as in TCP flags).

many of the text-based user-interface people at for example
router would disagree ;-).

anyway i have converted the TCP printer to new-style display order
to bring thinks back to consistency.

tx, for bringing this up.

/hannes
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.


Current thread: