Re: savefile.c patch

["Gisle Vanem" <giva () bgnett no>]

"Guy Harris" <guy () alum mit edu> said:

> Also, should we save the mode returned by "setmode()" and restore it 
> when we close a "pcap_t" or "pcap_dumper_t" that refers to the standard 
> input or output?


Since pcap_dump_close() doesn't have a pcap_t argument, where should
the oldmode come from? Can we have two module globals; oldmode_stdin, 
oldmode_stdout, assuming stdin/stdout won't be opened for capture more 
than once?

Ideally it should be "pcap_dump_flush(pcap_t *p)", but too late to
change that now.

--gv

-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.