Re: [PATCH]: pcap and zero copy.

["Gisle Vanem" <giva () bgnett no>]

"Yoann Vandoorselaere" <yoann () prelude-ids org> said:

> > I agree that many args should be 'const'ed, but your patch will break e.g.
> > Ethereal that binds to libpcap functions via dynamic lib-loading and function-
> > pointers.

> Huu, could you detail a little more here ? Don't see how it could break
> anything... 

In Ethereal's capture-wpcap.c:

#include <pcap.h>
...
int
#ifdef WPCAP_CONSTIFIED
pcap_lookupnet(const char *a, bpf_u_int32 *b, bpf_u_int32 *c, char *d)
#else
pcap_lookupnet(char *a, bpf_u_int32 *b, bpf_u_int32 *c, char *d)
#endif
{
        g_assert(has_wpcap);
        return p_pcap_lookupnet(a, b, c, d);
}

The WPCAP_CONSTIFIED was added recently AFAICT so it may not be
a problem anymore. But it could cause a redefine error with an "old" Ethereal
and your patch.

--gv

-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe