Re: What happened to alarm()?

["Gisle Vanem" <giva () bgnett no>]

"Guy Harris" <guy () alum mit edu> said:

> "pcap_break_loop()" shouldn't make things worse; I'll look at that.

There's an error in pcap_read_win32() where 'p->break_loop' is
tested only if PacketReceivePacket() received something.
I.e. can't break out of tcpdump on a quiet LAN. Simple fix:

--- pcap-win32.c.orig     Fri Nov 21 01:10:00 2003
+++ pcap-win32.c        Thu Nov 20 03:02:40 2003
@@ -146,7 +119,7 @@
         */
 #define bhp ((struct bpf_hdr *)bp)
        ep = bp + cc;
-       while (1) {
+       while (bp < ep) {
                register int caplen, hdrlen;

                /*
@@ -168,8 +141,6 @@
                                return (n);
                        }
                }
-               if (bp >= ep)
-                       break;

                caplen = bhp->bh_caplen;
                hdrlen = bhp->bh_hdrlen;
@@ -209,51 +180,20 @@
        register pcap_t *p;
        NetType type;

----------

Ignore the mismatching line numbers (I've done other private
patches).

--gv

-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe