tcpdump mailing list archives
typo in tcpdump-stdinc.h from CVS?
From: Hank Leininger <tcpdump-workers () progressive-comp com>
Date: Thu, 20 Mar 2003 01:48:39 -0500
Reviewing the current CVS patches, I noticed what looks like a small thinko in tcpdump-stdinc.h (diff'ed against a 2003-02 CVS snapshot): @@ -91,3 +102,17 @@ #ifdef INET6 #include "ip6.h" #endif + +#if defined(WIN32) || defined(MSDOS) + #define FOPEN_READ_TXT "rt" + #define FOPEN_READ_BIN "rb" + #define FOPEN_WRITE_TXT "wt" + #define FOPEN_WRITE_BIN "wb" +#else + #define FOPEN_READ_TXT "r" + #define FOPEN_READ_BIN FOPEN_READ_BIN + #define FOPEN_WRITE_TXT "w" + #define FOPEN_WRITE_BIN FOPEN_WRITE_TXT +#endif + +#endif /* tcpdump_stdinc_h */ The second line of the #else probably wants to be: + #define FOPEN_READ_BIN FOPEN_READ_TXT Of these I only see FOPEN_READ_TXT used so far, so the above won't have bitten yet; perhaps these are/were meant as an alternative to O_BINARY in util.c. -- Hank Leininger <hlein () progressive-comp com> - This is the TCPDUMP workers list. It is archived at http://www.tcpdump.org/lists/workers/index.html To unsubscribe use mailto:tcpdump-workers-request () tcpdump org?body=unsubscribe
Current thread:
- typo in tcpdump-stdinc.h from CVS? Hank Leininger (Mar 19)
- Re: typo in tcpdump-stdinc.h from CVS? Guy Harris (Mar 23)