Re: [DAQ][PATCH 1/3] fix --enable-xyz-module options

[Michael Altizer <xiche () verizon net>]

On 08/03/2010 06:49 AM, Florian Westphal wrote:
> the "--enable" options were treated like "--disable".
> ---
>   configure.ac |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 81c585f..42a3eeb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -96,7 +96,7 @@ AM_CONDITIONAL([BUILD_MODULES], [test "$disable_bundled_modules" = no])
>   # AFPacket Module
>   AC_ARG_ENABLE(afpacket-module,
>                 AC_HELP_STRING([--disable-afpacket-module],[don't build the bundled AFPacket module]),
> -              [enable_afpacket_module=no], [enable_afpacket_module=yes])
> +              [enable_afpacket_module="$enableval"], [enable_afpacket_module=yes])
>   if test "$enable_afpacket_module" = yes; then
>       AC_CHECK_HEADERS([linux/if_ether.h linux/if_packet.h], [], [enable_afpacket_module=no])
>   fi
> @@ -105,7 +105,7 @@ AM_CONDITIONAL([BUILD_AFPACKET_MODULE], [test "$enable_afpacket_module" = yes])
>   # Dump Module
>   AC_ARG_ENABLE(dump-module,
>                 AC_HELP_STRING([--disable-dump-module],[don't build the bundled Dump module]),
> -              [enable_dump_module=no], [enable_dump_module=yes])
> +              [enable_dump_module="$enableval"], [enable_dump_module=yes])
>   if test "$enable_dump_module" = yes; then
>       AC_CHECK_HEADER([pcap.h], [], [enable_dump_module=no])
>   fi
> @@ -114,13 +114,13 @@ AM_CONDITIONAL([BUILD_DUMP_MODULE], [test "$enable_dump_module" = yes])
>   # IPFW Module
>   AC_ARG_ENABLE(ipfw-module,
>                 AC_HELP_STRING([--disable-ipfw-module],[don't build the bundled IPFW module]),
> -              [enable_ipfw_module=no], [enable_ipfw_module=yes])
> +              [enable_ipfw_module="$enableval"], [enable_ipfw_module=yes])
>   AM_CONDITIONAL([BUILD_IPFW_MODULE], [test "$enable_ipfw_module" = yes])
>
>   # IPQ Module
>   AC_ARG_ENABLE(ipq-module,
>                 AC_HELP_STRING([--disable-ipq-module],[don't build the bundled IPQ module]),
> -              [enable_ipq_module=no], [enable_ipq_module=yes])
> +              [enable_ipq_module="$enableval"], [enable_ipq_module=yes])
>   if test "$enable_ipq_module" = yes; then
>       AC_CHECK_HEADERS([dnet.h netinet/in.h libipq.h], [], [enable_ipq_module=no])
>       AC_CHECK_HEADER([linux/netfilter.h], [], [enable_ipq_module=no],
> @@ -133,7 +133,7 @@ AM_CONDITIONAL([BUILD_IPQ_MODULE], [test "$enable_ipq_module" = yes])
>   # NFQ Module
>   AC_ARG_ENABLE(nfq-module,
>                 AC_HELP_STRING([--disable-nfq-module],[don't build the bundled NFQ module]),
> -              [enable_nfq_module=no], [enable_nfq_module=yes])
> +              [enable_nfq_module="$enableval"], [enable_nfq_module=yes])
>   if test "$enable_nfq_module" = yes; then
>       AC_CHECK_HEADERS([dnet.h netinet/in.h libnetfilter_queue/libnetfilter_queue.h], [], [enable_nfq_module=no])
>       AC_CHECK_HEADER([linux/netfilter.h], [], [enable_nfq_module=no],
> @@ -146,7 +146,7 @@ AM_CONDITIONAL([BUILD_NFQ_MODULE], [test "$enable_nfq_module" = yes])
>   # PCAP Module
>   AC_ARG_ENABLE(pcap-module,
>                 AC_HELP_STRING([--disable-pcap-module],[don't build the bundled PCAP module]),
> -              [enable_pcap_module=no], [enable_pcap_module=yes])
> +              [enable_pcap_module="$enableval"], [enable_pcap_module=yes])
>   if test "$enable_pcap_module" = yes; then
>       AC_CHECK_HEADER([pcap.h], [], [enable_pcap_module=no])
>   fi
Thanks for catching that, looks good to me.  All of those default to yes 
(really more like autodetect), so I'd never explicitly tried calling 
them in the --enable form :).

-Michael

------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Snort-devel mailing list
Snort-devel () lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/snort-devel