oss-sec mailing list archives

Re: Geany IDE not escaping filenames during compilation / build - a security issue or not?


From: Matthew Brush <mbrush () codebrainz ca>
Date: Wed, 12 Dec 2012 22:50:33 -0800

On 12-12-12 09:54 PM, Eitan Adler wrote:
On 12 December 2012 11:51, Jan Lieskovsky <jlieskov () redhat com> wrote:
The questions:
1) should Geany escape the filenames?,

Up to the maintainers.

2) is this a security issue or not?

Unlikely.  Is there a way a malicious document could cause code
execution without user action?


If I understand correctly, if someone messed with the user's configuration directory where the "geany.conf" file is stored, and they modified the "recent files" stored in there that Geany opens automatically on next startup, then assuming that it doesn't choke on the weird filename and that the user didn't notice the weird filename in several places in the GUI, they could technically blindly activate a build command, causing the malicious filename/command to run.

I have no idea how much of a risk it actually is (relative to someone already having hacked your machine/$HOME files), but I'm personally not opposed to going to reasonable lengths to ensure our code/program is secure.

Cheers,
Matthew Brush


Current thread: