Re: CVE Request (gpicview)

[Nico Golde <oss-security+ml () ngolde de>]

Hi Jan,
* Jan Lieskovsky <jlieskov () redhat com> [2008-09-01 11:25]:
> On Sun, 2008-08-31 at 01:46 +0200, Nico Golde wrote:
> > Same piece of code main-win.c doesn't look too trustworthy 
> > to me either:
> >
> >     690     int error = jpegtran (filename, "/tmp/rot.jpg" , code);
> >     691     if(error)
> >     692         return error;
> >     693 
> >     694     //now copy /tmp/rot.jpg back to the original file
> >     695     char command[strlen(filename)+50]; //this should not generate buffer owerflow
> >     696     // MS: didn't know, how to make it better, maybe an own copy routine
> >     697     sprintf(command,"cp /tmp/rot.jpg \"%s\"",filename);
> >     698     system(command);
>
> CVE-2008-3791 was allocated to handle the security issue related
[...] 
This only covers the insecure temporary file name creation.

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - nion () jabber ccc de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.

Attachment: _bin
Description: