Re: Pull Request: Created ssh-os.nse script #1728

[Richard Lam <richlam.dev () gmail com>]

Hello Nmap Team,

I was wondering if anyone has any feedback on this submission last year:

https://github.com/nmap/nmap/pull/1728

If there's either feedback on the code/documentation, or why it may not be
a suitable script for nmap.  I have been, and will continue to maintain the
SSH banners to keep the script up to date.

Thanks in advance,

Richard


On Thu, 12 Sep 2019 at 09:35, Richard Lam <richlam.dev () gmail com> wrote:

> Hello,
>
> Just wanted to follow-up to see if anyone has a chance to review and
> provide feedback for this submission.   Thank you.
>
> https://github.com/nmap/nmap/pull/1728
>
> regards,
> Richard
>
>
> On Fri, 6 Sep 2019 at 16:16, Richard Lam <richlam.dev () gmail com> wrote:
>
> > Hello,
> >
> > As the subject title infers.  I have submitted a script, titled
> > ssh-os.nse.  Welcome any feedback for improvement and/or criteria for
> > acceptance.  Thank you.
> >
> > -----------------
> >
> > Script identifies Ubuntu, FreeBSD, or Debian version based on response of
> > default SSH banner.
> >
> > Identifies the following versions:
> >
> > Ubuntu 4.10 to 19.04
> > FreeBSD 4.3 to 12.0-RELEASE
> > Debian 4.0 to 10.0
> >
> > Originally this work was for the service-os script from the nse script
> > ideas page <https://secwiki.org/w/Nmap/Script_Ideas#service-os>,
> > however, Ubuntu, FreeBSD, and Debian can be identified by default SSH
> > banner, without cross referencing a response from another service.
> > Consequently submitting this as a separate script.
> >
> > Banner information used to implement this script located:
> > https://github.com/richlamdev/ssh-default-banners
> >
> > ----------------
> >
> > regards,
> >
> > Richard Lam
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/