Re: [NSE] KNX Gateway Discover Script

[Daniel Miller <bonsaiviking () gmail com>]

Niklaus,

Thanks for taking my suggestions! There's still a bit of a problem
regarding the use of output tables: we need the output of subsequent runs
of the script to be identical in ordering. That's what
stdnse.output_table() provides. A regular Lua table will yield its keys in
an unpredictable order, except for integer keys (array-style tables). This
means that any place where you store result["label"] = value, the result
table should be created as a stdnse.output_table(). Along with this, we
should sort the gateways by address. The ipOps library has some useful
comparison functions for sorting IP addresses.

I'm sorry that your messages to the list keep getting spam-filtered. We
will try to sort that out when Fyodor gets back from DEF CON. I'm really
looking forward to testing your unicast script soon!

Dan

On Sat, Aug 8, 2015 at 10:09 AM, Niklaus Schiess <nschiess () adversec com>
wrote:

> Hi,
>
> thanks a lot for the feedback! I implemented all the suggestions and
> attached the new version of the script.
>
> Also, I already started to implement a unicast version which uses a
> different message type to reliably detect gateways based on the suggestion
> by Michael.
>
> Regards,
> Niklaus
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/