Re: [Patch] KRAD Ascii Art (A short and sweet patch)

[Jay Bosamiya <jaybosamiya () gmail com>]

Dan, List,

I've committed the randomization as revision 32919.

Thanks for the feedback on the double-quoting of shell variables. I
hadn't really thought of the repercussions of spaces in the variables,
and in this case, it is not necessary; but it is a good practice
nevertheless.

I agree that a contest might be fun. Will wait for Fyodor's comments on
this.

Cheers,
Jay

On Friday 30 May 2014 09:54 PM, Daniel Miller wrote:
> Jay,
>
> This patch looks great. One small change, which doesn't really matter
> in this case, but is a good-practice: double-quote shell variables
> that may contain whitespace. I would personally not commit any ascii
> art in a file with whitespace in the name, but this kind of quoting is
> a good habit to get into. I've attached a modified patch that you can
> use. Commit whenever you like!
>
> As we discussed, please hold off on committing any new ASCII art; just
> commit the randomization function for now. We need to decide how to
> choose what art gets displayed, and that's probably more up to Fyodor
> than you or I. I thought perhaps a contest might be fun!
>
> Dan

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/