Re: Re: [Bulk] Re: [Patch] Upgrade libpcap to 1.5.3

[Jay Bosamiya <jaybosamiya () gmail com>]

Gisle Vanem wrote:

> Have you tried to compile this on Win32? I mean, why are there 2 of these?
> 'Adapter' and  'ADAPTER'; are they the same?
With respect to the file that you are talking about (pcap-int.h), I really
haven't looked into that part. And nor have I tried compiling on Win32. The
only change that has been made to that file (i.e. the change from the
official libpcap) is there
in libpcap/NMAP_MODIFICATIONS/0004-Include-netpacket-packet.h-before-pcap-bpf.h.patch
(i.e. after you patch using the previously attached
libpcap_upgrade_to_1.5.3.patch). The rest of the changes that you see in
the pcap-int.h file are from the changes in the official libpcap
distribution itself. I'll look into it once I get the time, but as of now,
since it is there in the official latest release, I assume that both of
them need to be there.

Just to clarify, I have even modified the files in
libpcap/NMAP_MODIFICATIONS so as to reflect the latest modifications.

Daniel Miller wrote:
> I think there is a desire for Nmap to build cleanly "out of the box" with
> as few external dependencies as possible, hence the inclusion of libpcre,
> libpcap, and liblua. I haven't looked at the patches, but I would suspect
> some of them were to work around known bugs in the version that was
> included. Generally, these bugs should be forwarded to upstream, though.
The patches, from what I understand, are small tiny things that seem to
have not been forward to upstream for some reason. For example, if you look
through http://seclists.org/nmap-dev/2010/q3/796, Luis says that he sent a
report to the tcpdump-workers list but looking at the latest
https://raw.github.com/the-tcpdump-group/libpcap/master/pcap-linux.c, we
can clearly see that it isn't added in yet.

I guess we just will have to work with putting patches even when versions
change.


If there are no objections to the patch, then what must be done next in
order for it to be committed?
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/