Re: quake-server-info.nse

[Daniel Miller <bonsaiviking () gmail com>]

Ulrik,

This looks great! We don't often get submissions that have all the
required NSEdoc tags and such a clean formatting. I'm looking forward
to testing this later.

In the meantime, perhaps you could update the script to emit
structured XML output
(http://nmap.org/book/nse-api.html#nse-structured-output). You'll find
that this actually simplifies the script, since you can just return a
key-value table instead of formatting strings and using
stdnse.format_output. Also, I'd prefer not to have the form-feed
(0x0c) characters in the comments: whitespace should be limited to
0x20 (space) and 0x0a (line feed). I'm trying to collect these style
suggestions here: https://secwiki.org/w/Nmap/Code_Standards

Looking forward to trying this out and seeing your update!

Dan

On Fri, Feb 28, 2014 at 4:57 AM, Ulrik Haugen <ulrik.haugen () liu se> wrote:
> Hello!
>
> I've written an Nmap script for extracting information from a Quake game
> server as it is a potential reflector/amplifier. Bandwidth amplification
> factor is between about 3 and 8 depending on server/map names or players
> names if an attacker bothers to request the player info instead.
>
> The original Quake game engine is available under the gpl and Debian for
> instance packages it along with game-data-packager to create packages of
> the more restrictively licensed game data files.
>
> I'd be happy to have it included in Nmap or to get feedback on it!
>
> Best regards
> /Ulrik Haugen
>
>
> _______________________________________________
> Sent through the dev mailing list
> http://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/