Re: Enhanced nsock logging

[David Fifield <david () bamsoftware com>]

On Sat, Dec 15, 2012 at 01:53:37AM +0100, Henri Doreau wrote:
> Hi David,
>
> thanks a lot for testing and for the precious feedback.
>
> 2012/12/15 David Fifield <david () bamsoftware com>:
> > Thank you Henri, good-looking code as always.
> >
> > The Windows build doesn't like the variadic macro NSOCK_LOG_WRAP. It
> > fails to build with error C2010:
> >         nsock_log.h(64): error C2010: '.' : unexpected in macro formal parameter list
> > I'm also seeing
> >         include/nsock.h(142): error C2079: 'nsock_log_rec::time' uses undefined struct 'timeval'
> My understanding of msdn[1][2] makes me think that the patch attached
> should fix that, could you give it a try?

Including <winsock2.h> works.

You need to use just "..." and not "arg...". With that change, it errors
on a tricky construction in nsock_pcap.c:

nsock_pcap.c(238): error C2121: '#' : invalid character : possibly the result of a macro expansion
nsock_pcap.c(238): error C2059: syntax error : 'if'
nsock_pcap.c(238): error C2121: '#' : invalid character : possibly the result of a macro expansion
nsock_pcap.c(238): error C2121: '#' : invalid character : possibly the result of a macro expansion
nsock_pcap.c(238): error C2121: '#' : invalid character : possibly the result of a macro expansion
nsock_pcap.c(238): error C2121: '#' : invalid character : possibly the result of a macro expansion
nsock_pcap.c(238): error C2121: '#' : invalid character : possibly the result of a macro expansion

You might want to check that GCC is doing the right thing with this
construction as well.

David Fifield
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/