Nmap Development mailing list archives
Re: [PATCH] ncat - make check succeeds despite test failures
From: Daniel Miller <bonsaiviking () gmail com>
Date: Thu, 06 Dec 2012 12:50:10 -0600
On 12/06/2012 12:20 PM, olli hauer wrote:
Hm, the patch has one major issue. On Platforms where sh != bash let is not available. _______________________________________________ Sent through the dev mailing list http://nmap.org/mailman/listinfo/dev Archived at http://seclists.org/nmap-dev/
olli,Thanks for pointing that out. I've committed r30350 which makes the test POSIX-sh compliant.
* Changed "let X++" to "X=$((X + 1))" * Changed "if [ foo == bar ]" to "if [ foo = bar ]" * Changed shebang from "#!/usr/bin/env bash" to "#!/bin/sh" * Changed function declarations from "function func() {" to "func() {" Dan _______________________________________________ Sent through the dev mailing list http://nmap.org/mailman/listinfo/dev Archived at http://seclists.org/nmap-dev/
Current thread:
- [PATCH] ncat - make check succeeds despite test failures Andreas Stieger (Dec 02)
- Re: [PATCH] ncat - make check succeeds despite test failures David Fifield (Dec 03)
- Re: [PATCH] ncat - make check succeeds despite test failures Andreas Stieger (Dec 04)
- Re: [PATCH] ncat - make check succeeds despite test failures David Fifield (Dec 04)
- Re: [PATCH] ncat - make check succeeds despite test failures olli hauer (Dec 06)
- Re: [PATCH] ncat - make check succeeds despite test failures David Fifield (Dec 06)
- Re: [PATCH] ncat - make check succeeds despite test failures olli hauer (Dec 06)
- Re: [PATCH] ncat - make check succeeds despite test failures Daniel Miller (Dec 06)
- Re: [PATCH] ncat - make check succeeds despite test failures Andreas Stieger (Dec 04)
- Re: [PATCH] ncat - make check succeeds despite test failures David Fifield (Dec 03)