Re: [nsock] superfluous pcap_read_on_nonselect() call

[David Fifield <david () bamsoftware com>]

On Sat, Jul 14, 2012 at 12:20:41PM +0200, Henri Doreau wrote:
> Hello,
>
> it looks like the nsock function pcap_read_on_nonselect() is called
> even when not needed (i.e.: called on systems that provide selectable
> pcap FDs). I would suggest to protect the statement by a #ifndef
> PCAP_CAN_DO_SELECT.
>
> I have successfully tested it on linux and freebsd (that both have
> selectable pcap FDs), but since this was already in place for a long
> time (before nsock-engines) I would appreciate to get this simple
> patch (attached) reviewed to avoid introducing a regression.

This looks reasonable to me.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/