Re: [patch] More NSE bugfixes

[Patrick Donnelly <batrick () batbytes com>]

Hi Daniel,

On Sun, Jun 3, 2012 at 10:36 PM, Daniel Miller <bonsaiviking () gmail com> wrote:
> List,
>
> Decided to hunt bugs again, by running a debugging scan on my network
> [...]

I think we'll find many of these errors are bad global accesses. I've
attached the latest output of nse_check_globals (many of the bugs in
your post are already fixed but would have been found by this script).
While scripts (threads) have their own environment and are usually
immune to problems with setting/getting a global, there still are a
few real errors you can find. For example, the ipOps library is often
accidentally indexed as ipops (subject of another thread). There are
still some scripts which are using that which you'll find in the
attached output. Another example,
scripts/broadcast-tellstick-discover.nse has "stndse" used.

-- 
- Patrick Donnelly

Attachment: GLOBAL_ERRORS.gz
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/