Nmap Development mailing list archives
Re: [RFC][patch] XML structured script output
From: Djalal Harouni <tixxdz () opendz org>
Date: Sun, 27 May 2012 16:42:04 +0100
Hi Dan, Thank you for re-sending, can you please send a sample XML file to show the difference ? On Mon, May 21, 2012 at 08:57:38PM -0500, Daniel Miller wrote:
Congratulations everyone on version 6! For a year or so, I've been looking for feedback on my patch for XML structured output for NSE scripts [1], and as it has been a while, I thought I'd bring it up again. I've fixed a couple bugs since last time, and I've started keeping my local copy of the Nmap source under Git source control, so I can rebase my branch as development continues on the official source. I'm attaching 2 patches: nse-structured.diff has all the code changes to use XML output for scripts, and scripts-structured.diff patches a few scripts to take better advantage of the structured output. As far as impact to script writers, there shouldn't be much, since a table passed to stdnse.format_output() will work as it always has, as will simply returning a string from a script. In this regard, the functionality is largely opt-in. If the patch is accepted, I'll spend time updating existing scripts to structure their output. There is room for improvement: Currently, "horizontal lists" don't work; that is, comma-separated values on one line of normal output should be output as a list of <elem> elements in XML. The base functionality is there, with ScriptOutputNode.set_display(FLOW), but the logic to tie it in as a Lua function is missing. I don't figure this is a big deal, and can be added in later. Looking forward to hearing feedback! Dan
_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
-- tixxdz http://opendz.org _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- [RFC][patch] XML structured script output Daniel Miller (May 21)
- Re: [RFC][patch] XML structured script output Daniel Miller (May 24)
- Re: [RFC][patch] XML structured script output Djalal Harouni (May 27)
- Re: [RFC][patch] XML structured script output Daniel Miller (May 27)
- Re: [RFC][patch] XML structured script output Daniel Miller (May 29)
- Re: [RFC][patch] XML structured script output Fyodor (Jun 03)
- Re: [RFC][patch] XML structured script output (evaluation of nse-structured3 patch) David Fifield (Jun 13)
- Re: [RFC][patch] XML structured script output (evaluation of nse-structured3 patch) Daniel Miller (Jun 14)
- RE: [RFC][patch] XML structured script output (evaluation of nse-structured3 patch) Rob Nicholls (Jun 29)
- Re: [RFC][patch] XML structured script output (evaluation of nse-structured3 patch) Daniel Miller (Jun 29)
- Re: [RFC][patch] XML structured script output (evaluation of nse-structured3 patch) Patrick Donnelly (Jun 30)
- Re: [RFC][patch] XML structured script output (evaluation of nse-structured3 patch) Daniel Miller (Jun 30)
- Re: [RFC][patch] XML structured script output Daniel Miller (May 27)
- Re: [RFC][patch] XML structured script output (output diff) David Fifield (Jun 13)