Re: [NSE] http-traceroute

[Henri Doreau <henri.doreau () gmail com>]

Hi Hani,

the script works well and your code is neat and tidy, good job!

A couple comments:
  - I think script description should mention that this implementation
is based on the work of Nicolas Gregoire (nicolas.gregoire () agarri fr)
and Julien Cayssol (tools () aqwz com).
  - I noticed a couple unnecessary variable declarations (line 171,
"i" doesn't have to be declared, "response" is re-declared line 175).
There might be other ones. Can you have a look?

I also have a suggestion. I think the current output should be
displayed when verbosity level is >0. Otherwise I would suggest that
you attribute a score to each heuristic you apply, and set a
threshold. When score is greater than the threshold, default output
could simply mention that reverse proxies were detected (and give the
score, as an indicator of accuracy). What do you think?

Also, during initial discussions we were wondering whether the name
http-traceroute should be changed for something like
"http-reverse-proxies-detect" or similar. I'd like to have opinions
from the list about this.

Regards.

-- 
Henri
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/