Re: [NSE] Lua 5.2 Upgrade

[Patrick Donnelly <batrick () batbytes com>]

Hi Fyodor,

On Mon, Apr 9, 2012 at 7:04 PM, Fyodor <fyodor () insecure org> wrote:
> On Wed, Apr 04, 2012 at 01:43:38AM -0400, Patrick Donnelly wrote:
> > Over the past few months I've been working on a branch that upgrades
> > NSE to use Lua 5.2. I'll start off by giving you the location of the
> > branch so you can try it out:
>
> Thanks Patrick, this is exciting stuff!  I'm pretty sure we will want
> to upgrade to Lua 5.2.  I tested your branch
> (https://svn.nmap.org/nmap-exp/patrick/nse-lua52) on Linux and it
> seems to be working fine.  On Windows, it compiled, but I haven't been
> able to get it to work.  It gives me this message:
>
> $ ./nmap -A -T4 scanme.nmap.org
>
> Starting Nmap 5.61TEST5 ( http://nmap.org ) at 2012-04-09 15:56 Pacific Daylight Time
> NSE: Script Engine Scan Aborted.
> An error was thrown by the engine: ...ome\fyodor\nse-lua52\mswin32\nmap-5.61TEST5/nse_main.lua:902: attempt to call 
> upvalue 'unpack' (a nil value)
> stack traceback:
>        ...ome\fyodor\nse-lua52\mswin32\nmap-5.61TEST5/nse_main.lua:902: in function 'run'
>        ...ome\fyodor\nse-lua52\mswin32\nmap-5.61TEST5/nse_main.lua:1238: in function 
> <...ome\fyodor\nse-lua52\mswin32\nmap-5.61TEST5/nse_main.lua:1145>
>        [C]: in ?
> Nmap scan report for scanme.nmap.org (74.207.244.221)
> [Rest of Nmap report cut.  It was fine except that there wasn't any
>  NSE results]

This went unnoticed in the Linux build because Lua compatibility flags
were left on. I've corrected the bug in nse_main.lua and removed the
compatibility flags in our included liblua.

> Am I correct in assuming that this branch won't work with older
> versions of Lua?

Yes.

>  If so, can you update configure.ac so that it will
> always include the included (with Nmap) version of Liblua unless the
> system already has 5.2 or later?  Normal users won't know to specify
> --with-liblua=included.

Sure, I'll make that change.

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/