Nmap Development mailing list archives
Re: [NSE] broadcast-ping
From: Patrick Donnelly <batrick () batbytes com>
Date: Sun, 3 Jul 2011 18:16:46 -0400
On Sat, Jul 2, 2011 at 8:59 PM, Gorjan Petrovski <mogi57 () gmail com> wrote:
Here is a patch for listing all the interfaces in NSE. Please review it when possible.
Gorjan, the patch looks good but I have a few minor remarks. Please fix the formatting for the switch statement. It looks broken in the patch. Also, for the error condition where iflist == NULL, you need to return 2 instead of 1 because you are returning two values to Lua. After you have made those adjustments, please commit it. -- - Patrick Donnelly _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 02)
- Re: [NSE] broadcast-ping Patrick Donnelly (Jul 03)
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 04)
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 05)
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 05)
- Re: [NSE] broadcast-ping Toni Ruottu (Jul 06)
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 04)
- Re: [NSE] broadcast-ping Patrick Donnelly (Jul 03)
- <Possible follow-ups>
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 06)
- Re: [NSE] broadcast-ping Toni Ruottu (Jul 06)
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 10)
- Re: [NSE] broadcast-ping Patrik Karlsson (Jul 10)
- Re: [NSE] broadcast-ping Gorjan Petrovski (Jul 11)
- Re: [NSE] broadcast-ping Patrik Karlsson (Jul 11)
- Re: [NSE] broadcast-ping Toni Ruottu (Jul 06)