Re: [NSE] DNS update support

[Patrik Karlsson <patrik () cqure net>]

On 14 jan 2011, at 05.12, David Fifield wrote:

> On Tue, Jan 11, 2011 at 08:01:08AM +0100, Patrik Karlsson wrote:
> > On 10 jan 2011, at 02.58, David Fifield wrote:
> >
> > > On Mon, Jan 10, 2011 at 02:15:45AM +0100, Patrik Karlsson wrote:
> > > > Hi all,
> > > >
> > > > I just finished some work on the DNS library adding support for unauthenticated dynamic updates.
> > > > I'm including a patch that adds the support and a script dns-update that makes us of it.
> > > >
> > > > The script attempt to add a record specified as an argument and returns a message if it was successful.
> > > > Any comments or feedback are always appreciated.
> > >
> > > I get this error:
> > >
> > > ./nmap --datadir . --script=dns-update -d 192.168.0.1 -sU -p53 --script-args 
> > > dns-update.hostname=foo,dns-update.ip=3.3.3.3
> > >
> > > ./nselib/dns.lua:708: attempt to concatenate a nil value
> > > stack traceback:
> > >       ./nselib/dns.lua:708: in function <./nselib/dns.lua:704>
> > >       (tail call): ?
> > >       ./nselib/dns.lua:775: in function 'encode'
> > >       ./nselib/dns.lua:1254: in function 'update'
> > >       ./scripts/dns-update.nse:53: in function <./scripts/dns-update.nse:46>
> > >       (tail call): ?
> > >
> > > With "foo.bar.com" instead of "foo", the script finishes but doesn't
> > > make any output.
> >
> > Sorry my bad. I fixed the error by making some additional checks.
> > The script produces no output unless the DNS update is successful.
> > Do you think the script should produce a message similar to "Dynamic update of record nmap-test.cqure.net failed" on 
> > failure as well?
>
> No, I think no output is fine.
>
> > I'm including an updated script and a new patch file for dns.lua.
>
> Looks good, please commit.
>
> David Fifield


It's commited as r21771.

//Patrik
--
Patrik Karlsson
http://www.cqure.net
http://www.twitter.com/nevdull77





_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/