Re: [nmap-svn] r21222 - nmap/scripts

[David Fifield <david () bamsoftware com>]

On Mon, Nov 29, 2010 at 02:51:23PM -0500, Patrick Donnelly wrote:
> On Mon, Nov 29, 2010 at 2:16 PM,  <commit-mailer () insecure org> wrote:
> > Author: david
> > Date: Mon Nov 29 11:16:49 2010
> > New Revision: 21222
> >
> > Log:
> > Fixes to firewalk.nse from Henri Doreau: "The first one was due to my
> > ignorance that the first index of lua arrays is 1 (and not 0). Because
> > of that, I was setting a too high ttl value when retrieving it from
> > traceroute results. The second one was a syntax error on a
> > nmap.log_write() call."
> >
> >
> > Modified:
> >   nmap/scripts/firewalk.nse
> >
> > Modified: nmap/scripts/firewalk.nse
> > ==============================================================================
> > --- nmap/scripts/firewalk.nse   (original)
> > +++ nmap/scripts/firewalk.nse   Mon Nov 29 11:16:49 2010
> > [...]
> > @@ -439,7 +439,7 @@
> >
> >     if not Protocol then
> >       if nmap.verbosity() > 1 then
> > -        nmap.log_write("FIREWALK: Unsupported protocol: " .. proto)
> > +        nmap.log_write("stdout", "FIREWALK: Unsupported protocol: " .. proto)
> >       end
> >       return
> >     end
>
> Should this probably be to stderr? Do we have a policy on this?

We don't have a policy on this. I was wondering the same thing as I
committed it. nmap.log_write is hardly used. (Only in firewalk, ipidseq,
path-mtu, and qscan.) print_debug is much more common.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/