Nmap Development mailing list archives

small cosmetic patch against ncat / nping Makefie.in


From: olli hauer <ohauer () gmx de>
Date: Sat, 20 Nov 2010 16:02:50 +0100

The Makefile from ncat creates a directory (DESTDIR)$(pkgdatadir) which
is only used if HAVE_OPENSSL is defined, else it keeps empty.


The makefile from nping creates a directory "npingdatadir = @datadir@/nping"

What's the purpose of this (empty) directory?
I can't find any files intstalled into this directory or any usage in the code.

# grep -Ri NPINGDATADIR *
./nping/Makefile.in:npingdatadir = @datadir@/nping
./nping/Makefile.in:DEFS = @DEFS@ -DNPING_NAME=\"$(NPING_NAME)\"
-DNPING_URL=\"$(NPING_URL)\" -DNPING_PLATFORM=\"$(NPING_PLATFORM)\"
-DNPINGDATADIR=\"$(npingdatadir)\"
./nping/Makefile.in:    $(INSTALL) -d $(DESTDIR)$(bindir)
$(DESTDIR)$(mandir)/man1 $(DESTDIR)$(npingdatadir)
./nping/Makefile.in:    rm -rf $(DESTDIR)$(npingdatadir)
./nping/nping_winconfig.h:#ifdef NPINGDATADIR
./nping/nping_winconfig.h:      #define NPINGDATADIR "c:\\nmap" /* FIXME: I
really need to make this dynamic */


--
olli

Attachment: ncat.diff
Description:

Attachment: nping.diff
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/

Current thread: