Re: [NSE] http.lua cleanups

[Ron <ron () skullsecurity net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 1 Nov 2010 19:08:35 -0600 David Fifield <david () bamsoftware com> wrote:
> On Wed, Oct 27, 2010 at 11:03:01PM -0500, Ron wrote:
> > I've spent the past few days cleaning up http.lua functions, and
> > I'm pretty happy with the result I have now. Among other things, I:
> > o Updated the documentation on pretty much every function o Updated
> > the module documentation to discuss how to use http.lua, along with
> > an example o Changed the interface to http.pipeline to work be
> > significantly cleaner, and documented it (I also kept the old
> > interface, which prints a warning and calls the new function) o
> > Made functions 'local' that should have been, and that aren't being
> > used o Document and validate the 'options' table o Document the
> > 'response' table o Change nmap.registry.args.* to
> > stdnse.get_script_args() o Normalized indentation and style, where
> > possible, including function definitions ('function xxx()' instead
> > of 'xxx = function()'). 
>
> This looks good. You can commit it.
>
> In general, if you're making style changes only, and people aren't
> likely to object to the style changes, you can just commit them
> without asking. I appreciate you keeping backwards-compatible pipeline
> functions.
>
> Do you have a way to test (i.e., render) NSEDoc markup? I've been
> thinking we should make that easier for script authors.
>
> David Fifield
Although these are only style changes, they're pretty big ones so I wanted to have them double checked first. 

No, I have no way to render NSEDoc. It's mostly guesswork and fixing it later. 

Ron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkzPbREACgkQ2t2zxlt4g/RjLgCfUElhD1RoHrxpJ6cN5+h2oHNt
EIoAoLlidBS3EvzBk3FbmHzuiGI9BBcM
=cxxE
-----END PGP SIGNATURE-----
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/