Re: Payload Hexdump in --packet-trace and -d4 output

[David Fifield <david () bamsoftware com>]

On Wed, Jun 02, 2010 at 04:06:01PM -0400, jrf wrote:
> So I took a look and I have to defer to David. The function I copied
> from him looks significantly different than the nbase hexdump and it
> takes different arguments. Perhaps I should rename it to
> print_udp_payload and move the function somewhere else?
>
> Also a minor correction in my last email:
>
> On Wed, Jun 02, 2010 at 03:52:33PM -0400, jrf wrote:
>
> So for instance (but not authortatively (sp?)):
>   --packet-trace -d4 would do just UDP payload 
>   --packet-trace -d5 (or some higher number) would do the full packet

I wrote that print_hexdump function for your standalone payload
prototype that wasn't linked to nbase. Anything in Nmap should use an
Nmap hexdump function, and also the log_write infrastructure. (Don't
just use printf or you'll mess up XML output, for example.)

I don't think it makes sense to trace only UDP payloads. This sort of
thing could be useful if it was integrated into PacketTrace::trace and
PacketTrace::traceArp, so it applies to every packet.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/