Nmap Development mailing list archives
[PATCH] Nmap.nsi WinPcap Silent Install Code Cleanup
From: "Rob Nicholls" <robert () robnicholls co uk>
Date: Fri, 23 Apr 2010 13:30:39 +0100
I've tested this against a couple of systems (both normal and silent installs on 2003 x86 and Win7 x64) and everything looked fine, including David's NPFSTARTUP=NO option when I tested it on Win7. Enjoy! Rob -----Original Message----- From: nmap-dev-bounces () insecure org [mailto:nmap-dev-bounces () insecure org] On Behalf Of Rob Nicholls Sent: 22 April 2010 10:18 To: Fyodor Cc: nmap-dev () insecure org Subject: Re: [PATCH] Improved WinPcap x64 Support On Wed, 21 Apr 2010 18:50:33 -0700, Fyodor <fyodor () insecure org> wrote:
Thanks Rob. Given the lack of bug reports, this change seems to be working well!
Good to hear!
But I'm browsing through the NSI to help a user and have a question about this section added last October: InstDir64bit: ExecWait '"$INSTDIR\winpcap-nmap-4.11.exe" $1 /S /D=$\""$PROGRAMFILES64\WinPcap\"$\"' Goto InstDirDone InstDir32bit: ExecWait '"$INSTDIR\winpcap-nmap-4.11.exe" $1 /S /D=$\""$PROGRAMFILES\WinPcap\"$\"' I'm not sure if this is needed, as the winpcap-nmap.nsi seems to do some 64 bit detection too.
You're right, I don't think it is needed anymore. It was in the past because we needed to pass an installation directory that's appropriate for the OS as our WinPcap installer was originally written to prompt for one (and we obviously can't do that with a silent install). But in the latest update, everything is effectively hardcoded so files end up in the same place as the official installer (almost all of the files end up somewhere in the WINDOWS directory anyway) so I don't think it matters what we pass it anymore as I believe it's ignored completely. I'll try cleaning up that redundant code in Nmap.nsi and check that it doesn't break anything before submitting a patch. Rob _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Attachment:
nmap.nsi_winpcap_silent_install_cleanup.diff
Description:
_______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- Re: [PATCH] Improved WinPcap x64 Support Fyodor (Apr 21)
- Re: [PATCH] Improved WinPcap x64 Support Rob Nicholls (Apr 22)
- [PATCH] Nmap.nsi WinPcap Silent Install Code Cleanup Rob Nicholls (Apr 23)
- Re: [PATCH] Nmap.nsi WinPcap Silent Install Code Cleanup 'Fyodor' (Apr 23)
- [PATCH] Nmap.nsi WinPcap Silent Install Code Cleanup Rob Nicholls (Apr 23)
- Re: [PATCH] Improved WinPcap x64 Support Rob Nicholls (Apr 22)