Nmap Development mailing list archives
Re: [PATCH] Compilation failing without Lua (--without-liblua)
From: Patrick Donnelly <batrick () batbytes com>
Date: Sun, 24 Jan 2010 03:42:51 -0500
Hi Brandon, On Sun, Jan 24, 2010 at 3:35 AM, Brandon Enright <bmenrigh () ucsd edu> wrote:
A coworker of mine noticed if you try to configure Nmap using - --without-liblua the compilation is failing. Attached is a patch that fixes the compile by wrapping a #ifndef NOLUA around a few statements. For some reason I don't understand, without Lua, the C++ standard string header isn't in scope/defined when compiling Target.h so I had to add that too. Adding the #ifndef directives seems rather non-controversial to me but adding #include <string> to Target.h might not be the "right" fix. Is there any issue with me applying this patch as-is?
nse_main.h #includes <string> Patch looks fine to me. Off-topic: Wouldn't --without-nse be a better name for --without-liblua? We don't have --without-python to exclude Zenmap after all :) -- -Patrick Donnelly "Let all men know thee, but no man know thee thoroughly: Men freely ford that see the shallows." - Benjamin Franklin _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://seclists.org/nmap-dev/
Current thread:
- [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Patrick Donnelly (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Patrick Donnelly (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Brandon Enright (Jan 24)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Fyodor (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Kris Katterjohn (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Fyodor (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) David Fifield (Jan 26)
- Re: [PATCH] Compilation failing without Lua (--without-liblua) Patrick Donnelly (Jan 24)