Re: [PATCH] Shortening scan time with SO_DONTROUTE

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/04/2009 10:55 PM, Fyodor wrote:
> On Thu, Jan 01, 2009 at 02:10:50AM -0600, Kris Katterjohn wrote:
> > I've attached a patch for the SO_DONTROUTE changes, and one for adding the
> > probably misplaced/misnamed XML attribute for the scan time.
>
> Hi Kris.  The XML total time attribute patch looks reasonable to me.
> The information is available in a comment tag right after the
> <runstats> section, but having to parse that is somewhat ugly.  Feel
> free to check it in if you will:
>
> o Change the attribute name from "total" to "totaltime" or just
>   "elapsed" as I think those names are a bit easier to understand in
>   this context.

Cool, I think I'll go with "elapsed".

> o Maybe follow the elapsed time value with an "s" so it is more
>   obvious it is in seconds?

I'd prefer not, since it can be easily used as an actual floating point number
when parsing it without the "s" (like with Ruby's to_f method which I used in
my parser when writing my SO_DONTROUTE script).  But if there is some demand
for it there, having the "s" isn't a huge deal.  For the purpose of my script,
which was the basis for this, either would have been fine.

> o The docs/nmap.dtd has to be updated for XML format changes.
>
> Cheers,
> -F

Thanks,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIcBAEBAgAGBQJJYaMxAAoJEEQxgFs5kUfuuG0QAMnYDGC+mNG4FmXj99J02QfV
n1y8HeVIEJHs6/CNW3LEJfpDg5rfzKbSwsFshl5u5WUhFq1HNsTY3VxLngtssjHx
6X5tjq7uiy7pDUq38b83lNIqV9OlMmg2c7i+p7rET8CmwRxE3sCNbWtnv4Q/hozi
gwF2eylFIG1VE9Lv/O4YUwUSyAhYkQF+0b3hgF5ZszNWAH1XQTk7DDPUSkOXmf5L
kBrGDeLuctC5YWmpk3W2FIGyv+AZP7npMaSVfCPkrKgkDTuw6HKKrUlMWv+vkcmv
U55yLsqex6OB50MRlOZ20292cJ/XzcmWF+xUi9p575vmxPbNGOXdgbnfcRkFGvwa
MNXl1T5bjGFvlVTAtJ4khphMGOIo34VEw5qOlptpwtXb9G9V0yahKXLo8yAeIUy2
EgeLj8tpk+mCL1lsAEzFMB8zZGcMjBYfR7TFbmRSqjzjfnds1JibdrYxvyuobhoa
c0SvrVOf72egSbFnLzw1+16L11zwDXVN2UQcEQ6yhcwg+65Pta0XGBv11Q8wvCi4
8wgYg1vLk8yqqgAWOSNIjBg4A0AxWAHJ5MFu0+OoEDURiAxv3cQPLAupDb9RQxYT
jGfmOrxcKzLlzVsDx8HxERA0KeOjUEHCctNPvSCNBSPEbpfB8L0D2eL7t5iXXvJU
UCJbw2reBM3xrZDhVuf6
=8Hoj
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org