Nmap Development mailing list archives
Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters
From: Sven Klemm <sven () c3d2 de>
Date: Fri, 10 Oct 2008 20:54:50 +0200
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Patrick Donnelly wrote:
It's probably best that this library's design decisions not be changed at this point. lpack is a fairly common library in the Lua community and people would not expect this to error. From just a quick search of the code, there appears to be no intentionally thrown errors by the library. It is also highly probable that large pieces of this library be integrated into a struct library in Lua 5.2, in which case we will most likely remove this library. In the interest of consistency, we should not change something unless it is truly warranted.
We already have a quite modified version. We use different conversion specifiers than lpack, lpack does not support hex conversion and is not platform independent. bin.pack('H','not hex') returning "\xe0" seems very wrong to me. I think accepting this input will probably hide programming errors. Do you have any pointers were the integration is discussed? A web search did not return anything useful. Cheers, Sven -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkjvpPoACgkQevlgTHEIT4a3TACaA7lI0lGg4259R4nE9RQCDRgU bccAn01wm2BfTLlMu8PgDYHWp07h/9bl =IDMK -----END PGP SIGNATURE----- _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- [NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters David Fifield (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 12)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 12)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters David Fifield (Oct 12)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 12)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Sven Klemm (Oct 10)
- Re: [NSE][PATCH] throw an error in bin.pack for illegal hex characters Patrick Donnelly (Oct 10)