Re: [NSE][PATCH] dns.lua timeout based on nmap.timing_level()

[Fyodor <fyodor () insecure org>]

On Mon, Sep 15, 2008 at 12:59:49PM -0600, David Fifield wrote:
> On Sun, Sep 07, 2008 at 05:40:04AM +0100, jah wrote:
> > The attached changes the socket timeout used in dns.sendPackets which is
> > currently a very long 10 seconds to use values based on nmap timing
> > templates.  The times used would be 10 seconds for T0, 7s, 5s, 3s and 2s
> > for T4 and T5.
> > It also adds the ability to specify timeout in the options table passed
> > to dns.query().
>
> Thanks, the patch looks good and I've committed it.

Looks good, but the idea of a 2s NSE DNS timeout by default (even with
-T4) makes me nervous.  So I've changed it to a minimum of 4s for the
default.  If a script needs faster timeouts for some reason, they can
always pass a lower value.

I'm not opposed to 2s if someone can present a pretty good argument or
empirical data that 2s is sufficient.

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org