Re: [NSE][PATCH] datafiles.lua

[jah <jah () zadkiel plus com>]

On 13/09/2008 08:23, Sven Klemm wrote:
> thanks for testing and posting your opinion and your patch. I've
> applied both patches.
> I have one more patch for datafiles. Currently parse_rpc(),
> parse_protocols() and parse_services() don't really have any
> functionality on their own but just call parse_file() with the
> filename as argument. So I removed the common_files table and moved
> the parse instructions to those functions. This certainly makes
> parse_file() nicer as we don't have to check for common_files in
> parse_file()
Hi Sven,

I envisioned the possibility of removing the
parse_protocols/services/rpc functions at some point in the future.  The
common_files table holds a default format for the returned data for each
file and allows simply calling, for example, parse_file( "nmap-services"
) and can easily be extended to include any future data files that might
be included with nmap.

Personally, I think that script writers will find it more intuitive to
call parse_file in this way than being required to call specific
functions for the various data files.  What do you think?

Regards,

jah

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org