Nmap Development mailing list archives

[patch] concurrent make fix


From: Michal Januszewski <michalj () gmail com>
Date: Sat, 30 Aug 2008 23:58:20 +0200

nmap's makefile contains a race condition which can lead to build
failures when using more than one make job (make option -jx, x > 1),
see e.g. [1].  The problem is caused by libnsock using libnbase,
without specifying an explicit dependency in the Makefile.  The
attached patch fixes this by adding the dependency.

[1] https://bugs.gentoo.org/show_bug.cgi?id=235995

---

diff -Naurp nmap-4.68-orig/Makefile.in nmap-4.68/Makefile.in
--- nmap-4.68-orig/Makefile.in  2008-08-30 01:04:10.000000000 +0200
+++ nmap-4.68/Makefile.in       2008-08-30 01:04:45.000000000 +0200
@@ -101,7 +101,7 @@ nbase_build: $(NBASEDIR)/Makefile
        @echo Compiling libnbase;
        cd $(NBASEDIR) && $(MAKE)
 
-nsock_build: $(NSOCKDIR)/src/Makefile
+nsock_build: $(NSOCKDIR)/src/Makefile nbase_build
        @echo Compiling libnsock;
        cd $(NSOCKDIR)/src && $(MAKE)
 


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org


Current thread: