Nmap Development mailing list archives
Re: [PATCH] Canonicalize trailing newlines on calls to error()
From: Fyodor <fyodor () insecure org>
Date: Thu, 20 Dec 2007 19:38:39 -0800
On Sat, Dec 15, 2007 at 01:27:16AM +0000, Brandon Enright wrote:
As you can see, a trailing newline is always included in a call to error(). Rather than remove the extra newline in error() I went ahead and looked through the code for all calls to error where the format string included a redundant "\n" and removed it. I didn't do this for *every* call to error() though, there are a few that will only appear once or are fatal enough that the probably deserve and extra break after them to hopefully get the attention of someone. The patch is attached.
Thanks Brandon, I've applied this patch in SVN. Cheers, -F _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- [PATCH] Canonicalize trailing newlines on calls to error() Brandon Enright (Dec 14)
- Re: [PATCH] Canonicalize trailing newlines on calls to error() Fyodor (Dec 20)