Re: [Patch] Traceroute, Windows localhost scan fix

[Kris Katterjohn <katterjohn () gmail com>]

Eddie Bell wrote:
> Hey all,
>
> Traceroute did not check to see if it was scanning local-host, so
> pcap_open_live failed. This patch changes traceroute to ignore
> local-host and print a warning message.
>
> The patch is against the latest SVN version of nmap, Thanks to Alan
> for finding this bug.
>
> cheers
> - eddie

Hey Eddie,

I was looking at your patch, and the checking of pd that's being added 
doesn't look necessary because my_pcap_open_live() only returns a good 
descriptor.  Here's the comment (tcpip.h) on my_pcap_open_live():

/* Calls pcap_open_live and spits out an error (and quits) if the call 
fails.  So a valid pcap_t will always be returned. */


(Not a big deal, but hey)

I hope my patches/fixes/comments on Traceroute don't come across bad; I 
really like your work, it's great! :)

Thanks,
Kris Katterjohn

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org