Nmap Development mailing list archives
Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock
From: Kris Katterjohn <katterjohn () gmail com>
Date: Sun, 31 Dec 2006 20:26:24 -0600
Jan Engelhardt wrote:
On Dec 31 2006 19:01, Kris Katterjohn wrote:Jan Engelhardt wrote:On Dec 31 2006 16:24, Fyodor wrote:On Sat, Dec 16, 2006 at 08:51:44PM -0600, Kris Katterjohn wrote:This just changes the C++ comments (//) to C comments (/**/) in nmapfe/* and nsock/* since some older C compilers don't like any C99 additions.Thanks, I have applied this, and also your superscan prototype patch.Are these "older compilers" even able to compile the whole nmap package?configure finds a C compiler for the C sources (nsock, nmapfe, etc) and a C++ compiler for the main nmap stuff. So the older compilers shouldn't be able to compile it all :)I don't get what you want to say by that. I was referring to, more precisely: are the C parts of nmap "clean enough" so that old compilers can do the work? Since you mentioned C99 //, I thought of C99
I thought you were referring to the old compilers being able to compile all of nmap ("whole nmap package" as you put it).
initializers that might happen to be around somewhere. (If I had to judge: go with C99, and forget old compilers.)
When it's something basic and costs nothing (like // vs /**/), why not have it compatible with older ones?
-`J'
-Kris _______________________________________________ Sent through the nmap-dev mailing list http://cgi.insecure.org/mailman/listinfo/nmap-dev Archived at http://SecLists.Org
Current thread:
- [PATCH] Change C++ comments to C comments in nmapfe and nsock Kris Katterjohn (Dec 16)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Fyodor (Dec 31)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Jan Engelhardt (Dec 31)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Kris Katterjohn (Dec 31)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Jan Engelhardt (Dec 31)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Kris Katterjohn (Dec 31)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Jan Engelhardt (Dec 31)
- Re: [PATCH] Change C++ comments to C comments in nmapfe and nsock Fyodor (Dec 31)