Re: [PATCH] Remove unused "timing" option from long_options in nmap.cc

[Fyodor <fyodor () insecure org>]

Thanks for all of your patches, which are coming almost as fast as I
can apply them :).  I have just processed a bunch:

> The attached patch removes the unused "timing" option from the
> long_options list in nmap_main().

Thanks, applied.

> The attached patch uses memset() instead of looping in nmap.cc.

Applied.

> The attached patch checks for a NULL 'howmany' pointer in getsysroutes()
> before going through the rest of the function.

Applied.

> The attached patch checks to see if an exclude list has been given on
> the command line before opening an exclude file. This way the check is
> done on both sides instead of just checking for the exclude file when
> getting the list from the command line.

Thanks, applied.

> The attached patch removes mmap-related #defines (PROT_* and MAP_SHARED)
> under the #ifdef WIN32 in utils.h. The PROT_* and MAP_SHARED are only
> used in mmapfile() under the #ifndef WIN32.

Applied.

> The attached patch uses Strncpy() instead of using strncpy() and placing
> the NULL byte at the end of 'o.device'. I also used 'sizeof(o.device)'
> instead of "63" ("64" should be passed to Strncpy() anyway).

Applied.

> The attached patch uses sizeof on the correct variable in parseArp() in
> tcpip.cc.

Thanks, applied.

> The attached patch removes a duplicate strcasestr("SYN") in
> parse_scanflags() in nmap.cc

Applied.

> The attached patch replaces "max-retransmissions" with "max-retries"
> in an error message in nmap.cc

Thanks, applied.

> The attached patch makes optcmp() return earlier when the string lengths
> don't match. Instead of going through the whole loop and then testing to
> see if we haven't hit the NULL byte, this tests the lengths before the loop.

I'm not at all sure this will be faster.  And even if it is, we
probably don't need to optimize command-line parsing time as I imagine
that is immaterial anyway.

> The attached patch simplifies parse_bounce_argument() by removing
> duplicate code. I just sorta pulled out the duplicated things and
> rearranged it a bit.

Thanks, applied.

Cheers,
Fyodor


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org